feat: Added realistic template for sd-tag#2889
Conversation
github-project-automation
Bot
moved this to 📋 Backlog
in Solid Design System Project Board
🦋 Changeset detectedLatest commit: acd7419 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🚀 Storybook has been deployed for branch |
There was a problem hiding this comment.
This things are not as in figma:
- Remove "Risk" in each tag of the section "Filter Tag Group with Risk"
- "Moderate" instead of "Moderated" in section "Filter Tag Group with Risk"
- In this section "Removable Filter Tag Group" the underline of "Remove..." is starting before the R (it has one space more then it should)
- In this section "Removable Filter Tag Group" in figma the space between "ETFs" tag and "Remove filters" is bigger then in code. in figma "Remove filters has a left padding of 16.
- in this section "Tag Group with Links" tags are suposed to hug horizontally the content as in figma. they should not have all the same horizontal size.
Assign me again once solved. I will remove my assignment
…xed the wrong underline start and added margin between tags and link and fixed horizontal size
balco0110
assigned
mariohamann,
smfonseca,
martascorreia,
rahulsuvarna18 and
auroraVasconcelos and unassigned
mariohamann,
smfonseca,
martascorreia,
rahulsuvarna18,
balco0110 and
auroraVasconcelos
…olor and fixed the chanhing site on remove click
Hey @martascorreia, when linking a template, use the component’s name if it’s the main component of that template (like in this case). Only use the story name when the template includes multiple components and the one you’re linking is not the main one. You can find more details about documenting in Storybook here: https://solid-design-system.fe.union-investment.de/docs/?path=/docs/packages-docs-contributing--docs |
balco0110
assigned
smfonseca and unassigned
mariohamann,
smfonseca,
martascorreia,
rahulsuvarna18,
balco0110 and
auroraVasconcelos
github-project-automation
Bot
moved this from 👀 In review
to ✅ Done
in Solid Design System Project Board
7 participants
Description:
Closes: #2134
Definition of Reviewable: